Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refine dataset_type validation #587

Open
kburke opened this issue Dec 11, 2023 · 1 comment
Open

refine dataset_type validation #587

kburke opened this issue Dec 11, 2023 · 1 comment
Labels
P Pitt dev team

Comments

@kburke
Copy link

kburke commented Dec 11, 2023

For initial release, new values for dataset_type on a Dataset entity are limited to a Dataset type recognized by UBKG, possibly followed by a single space and square brackets with non-validated content.

Revise the error message if exactly one space is the appropriate requirement, or revise the regular expression for validation if we are flexible about the number of spaces. This will help avoid issues like: #586

If new constraints for validating content inside the square brackets are available, this work can be done with that work.
https://github.com/hubmapconsortium/manual-data-ingest/issues/268#issuecomment-1848614060

@kburke kburke added the P Pitt dev team label Dec 11, 2023
@yuanzhou
Copy link
Member

9/23/2024 Notes from Bill

<valid_dataset_type> [*] needs to remain as a valid value for HIVE processed dataset types. We don’t have a specific list of

  • a) individual processed dataset types or
  • b) what goes inside of the brackets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P Pitt dev team
Projects
Status: Backlog
Development

No branches or pull requests

2 participants