Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GET /datasets/prov-info and GET /samples/prov-info #752

Open
yuanzhou opened this issue Oct 10, 2024 · 0 comments
Open

Remove GET /datasets/prov-info and GET /samples/prov-info #752

yuanzhou opened this issue Oct 10, 2024 · 0 comments

Comments

@yuanzhou
Copy link
Member

These two endpoints GET /datasets/prov-info and GET /samples/prov-info are no longer being used, confirmed with Ivan and Brendan from PSC. Considering these are the API endpoints, we can't really return a deprecation warning message.

  • Remove them in Smart API yaml spec
  • Remove each endpoint function in app.py
  • Ensure they are removed from hubmap-sdk too
  • Remove the two endpoints from AWS API Gateway

Note: Ivan at PSC still needs datasets/<id>/prov-info?format=json to build a submission for CFDE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant