-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update metadata, histogram, visualization, violin plot modules component #772
base: cde-mvp2
Are you sure you want to change the base?
Conversation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit d6528f2. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution
✅ Successfully ran 5 targetsSent with 💌 from NxCloud. |
🚀 Preview Deploy Report Updated✅ Successfully deployed preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Bhushan! Thanks so much for the quick work on this: I love the smoothness of the interactions for showing/hiding the unknown metadata and expanding/collapsing the metadata panel.
A couple of questions:
- Is it possible to implement the icon button micro tooltips for expand/collapse + more?
- Is it possible to use the basic text button for the top two metadata entries in the sample visualizations?
Looking so good! Thanks for all!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love those tooltips! Thanks for getting those squared away. They look/feel perfect!
Is it possible to get a hover state on the basic text button in the metadata panel? This is what I see when I hover on the prototype vs the preview:
Prototype
Preview
…into metadata-module
Quality Gate passedIssues Measures |
Updated the metadata & histogram component on the cde vis page according to current spec