Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submit Priv Check not including Publications #301

Open
BirdMachine opened this issue Mar 31, 2023 · 1 comment
Open

Submit Priv Check not including Publications #301

BirdMachine opened this issue Mar 31, 2023 · 1 comment
Labels

Comments

@BirdMachine
Copy link
Contributor

https://github.com/hubmapconsortium/ingest-api/blob/d04106f3fb3114cfc8e57044fc8ddd06759b80f9/src/app.py#LL1146C11-L1146C11

if entity_type == 'dataset':

Seems as though Publications are not being included with superclass Datasets when checking permissions; Returns false on publication entities that should be true

@BirdMachine BirdMachine added the P label Mar 31, 2023
@yuanzhou
Copy link
Member

@BirdMachine @shirey we had released the Publications work, it seems this issue has not been addressed accordingly. Can you verify and confirm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready
Development

No branches or pull requests

2 participants