Welling/run background subtraction parallel control rebased #719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch cannot be deployed until a version of codex-pipeline downstream of both a4c9d72 and 4f78897 has been deployed, since it invokes a command line argument added by those mods. This branch adds a parameter to the invocation of codex-pipeline:run_background_subtraction.cwl in the codex_cytokit.py DAG which limits the amount of parallelism used by the Docker container in that step. Previously parallelism was not specified so it defaulted to the number of cores on the node, which is not what we want.
This change does limit the parallelism in run_background_subtraction, which is the last unlimited bit of the DAG's invocation of the codex-pipeline repo. It makes very little difference to running time in practice. The parallelism of the SPRM repo is still unlimited, so the codex_cytokit DAG still presents parallelism problems.