-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset types url #1472
Dataset types url #1472
Conversation
Attempt to Load Locally stored UBKG Data first, and re-populate from…
Update Dataset form, collections, Display subtype utility, Collections & EPICollections handling of Display Subtypes
@BirdMachine I noticed this usage: ingest-ui/src/src/service/search_api.js Lines 266 to 287 in 17ff775
The truth is we had deprecated this |
@@ -71,7 +71,8 @@ export function ubkg_api_get_organ_type_set() { | |||
* | |||
*/ | |||
export function ubkg_api_get_dataset_type_set() { | |||
let url = `${process.env.REACT_APP_UBKG_API_URL}/valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP`; | |||
// let url = `${process.env.REACT_APP_UBKG_API_URL}/valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP`; | |||
let url = `${process.env.REACT_APP_UBKG_API_URL}/dataset-types?application_context=HUBMAP`; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlanSimmons before merging this PR, I wanted to confirm with you if moving from /valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP
to /dataset-types?application_context=HUBMAP
is desired?
In entity-api, we are still using this /valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP
for dataset_type
validation when a new dataset gets created or existing dataset gets updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alan has confirmed this.
Update Dataset Type URL for UBKG Service (#1440)
Update Dataset form, Publications form, Display subtype utility, Collections & EPICollections handling of Display Subtypes
Remove unused search_api_get_assay_list from search api service