Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset types url #1472

Merged
merged 5 commits into from
Sep 24, 2024
Merged

Dataset types url #1472

merged 5 commits into from
Sep 24, 2024

Conversation

BirdMachine
Copy link
Contributor

@BirdMachine BirdMachine commented Sep 17, 2024

Update Dataset Type URL for UBKG Service (#1440)
Update Dataset form, Publications form, Display subtype utility, Collections & EPICollections handling of Display Subtypes
Remove unused search_api_get_assay_list from search api service

yuanzhou and others added 2 commits September 13, 2024 10:11
Attempt to Load Locally stored  UBKG Data first, and re-populate from…
Update Dataset form, collections, Display subtype utility, Collections & EPICollections handling of Display Subtypes
@yuanzhou
Copy link
Member

@BirdMachine I noticed this usage:

export function search_api_get_assay_list(params) {
// So the api defaults to primary even if False is passed as ?primary=false
var primaryParam = {};
if (params) {
primaryParam = { params: params };
}
return (
axios
// Only regards flag via url for some reason?
.get(`${process.env.REACT_APP_SEARCH_API_URL}/assaytype?primary=true`)
.then((res) => {
let data = res.data;
let dtListMapped = data.result.map((value, index) => {
return value;
});
return { status: res.status, data: dtListMapped };
})
.catch((error) => {
return { error };
})
);
}

The truth is we had deprecated this search-api/assaytype call and very soon it'll be removed. Can you double check and see if we can get rid of it from ingest-ui?

@@ -71,7 +71,8 @@ export function ubkg_api_get_organ_type_set() {
*
*/
export function ubkg_api_get_dataset_type_set() {
let url = `${process.env.REACT_APP_UBKG_API_URL}/valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP`;
// let url = `${process.env.REACT_APP_UBKG_API_URL}/valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP`;
let url = `${process.env.REACT_APP_UBKG_API_URL}/dataset-types?application_context=HUBMAP`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AlanSimmons before merging this PR, I wanted to confirm with you if moving from /valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP to /dataset-types?application_context=HUBMAP is desired?

In entity-api, we are still using this /valueset?parent_sab=HUBMAP&parent_code=C003041&child_sabs=HUBMAP for dataset_type validation when a new dataset gets created or existing dataset gets updated.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alan has confirmed this.

@yuanzhou yuanzhou merged commit efe90a4 into dev-integrate Sep 24, 2024
3 checks passed
@yuanzhou yuanzhou mentioned this pull request Sep 24, 2024
@yuanzhou yuanzhou deleted the datasetTypesURL branch October 16, 2024 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants