Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Welling/semantic versions #53

Merged
merged 10 commits into from
May 2, 2024
Merged

Welling/semantic versions #53

merged 10 commits into from
May 2, 2024

Conversation

jswelling
Copy link
Collaborator

This PR:

  • Adds an initial 'version' string to each plugin test class. All are marked as version "1.0.0".
  • Adds a pytest which verifies that each class has a valid semantic version.

gesinaphillips
gesinaphillips approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@gesinaphillips gesinaphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! The linters are catching some errors, will need an update before the GitHub action will pass.

gesinaphillips
gesinaphillips reviewed Apr 18, 2024
View reviewed changes
Copy link
Contributor

@gesinaphillips gesinaphillips left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please handle "x.x" case as well as "x.x.x"

@gesinaphillips gesinaphillips merged commit bebbb49 into devel May 2, 2024
8 checks passed
@gesinaphillips gesinaphillips deleted the welling/semantic_versions branch May 2, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gesinaphillips gesinaphillips gesinaphillips approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jswelling @gesinaphillips