fix(element3): add change emit for switch

hug-sun · Jan 1, 2021 · 1c5d43f · 1c5d43f
1 parent e5fe4c8
commit 1c5d43f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/packages/element3/src/components/Switch/src/Switch.vue b/packages/element3/src/components/Switch/src/Switch.vue
@@ -72,7 +72,7 @@ export default {
       default: ''
     }
   },
-  emits: ['update:modelValue', 'update:change'],
+  emits: ['update:modelValue', 'change'],
   setup(props, { emit }) {
     const {
       activeValue,
@@ -167,7 +167,7 @@ const useClick = ({
     const newValue =
       isChecked && isChecked.value ? inactiveValue.value : activeValue.value
     emit('update:modelValue', newValue)
-    emit('update:change', newValue)
+    emit('change', newValue)
   }
 
   return {

diff --git a/packages/element3/src/components/Switch/tests/Switch.spec.js b/packages/element3/src/components/Switch/tests/Switch.spec.js
@@ -162,4 +162,15 @@ describe('Switch', () => {
 
     expect(wrapper.emitted('update:modelValue')).toEqual([['3']])
   })
+
+  it('should emit change eventName when changed ', async () => {
+    const wrapper = mount(Switch, {
+      props: {
+        modelValue: false
+      }
+    })
+
+    await wrapper.trigger('click')
+    expect(wrapper.emitted('change')[0]).toEqual([true])
+  })
 })