Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UFOGen to research projects #10217

Open
wants to merge 21 commits into
base: main
Choose a base branch
from

Conversation

ParagEkbote
Copy link
Contributor

@ParagEkbote ParagEkbote commented Dec 13, 2024

What does this PR do?

As discussed previously, I have moved the UFOGen scheduler and the code shared by its co-authors to examples/research projects.

I have also followed the same approach that was talked about in #10046. The implementation added has been kept simplistic to avoid confusion as well. Please let me know if any further corrections are needed and I will make the necessary changes.

Fixes #10162 and closes #6133

Before submitting

Who can review?

cc: @yiyixuxu

@ParagEkbote ParagEkbote changed the title Move UFOGen to examples/research projects Move UFOGen to research projects Dec 13, 2024
@hlky
Copy link
Collaborator

hlky commented Dec 13, 2024

Not sure research projects is the right place for a clone of an entire repo? Looks like the scheduler is the main thing and that was already added in community scripts.

@ParagEkbote
Copy link
Contributor Author

ParagEkbote commented Dec 13, 2024

The issue is that after the release of the UFOGen repo, the authors didn't publicly release a trained model based on the paper and it gets quite difficult to verify the results. ㋡

The folder contains the code needed to experiment and verify the results in the future, thereby I chose to add the majority of files.

Please let me know if I need to perform any necessary changes.

@ParagEkbote
Copy link
Contributor Author

Could you please review?

cc: @yiyixuxu

@ParagEkbote
Copy link
Contributor Author

I need advice on how to proceed further for this PR. Any advice you could give is greatly appreciated.

@yiyixuxu

@ParagEkbote
Copy link
Contributor Author

Could you please review the changes?

cc: @yiyixuxu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move UFOGen Pipeline and Scheduler to Research Projects
3 participants