Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mlx-image #539

Merged
merged 3 commits into from
Mar 14, 2024
Merged

add mlx-image #539

merged 3 commits into from
Mar 14, 2024

Conversation

riccardomusmeci
Copy link
Contributor

No description provided.

Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit :)

@@ -532,6 +532,13 @@ export HF_HUB_ENABLE_HF_TRANS: string[]FER=1
huggingface-cli download --local-dir ${nameWithoutNamespace(model.id)} ${model.id}`,
];

export const mlxim = (model: ModelData): string[] => [
`pip install mlx-image
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need for installation part :)

@@ -192,6 +192,15 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = {
snippets: snippets.mlx,
filter: true,
},
"mlxim": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"mlxim": {
mlxim: {

Linter will complain otherwise :)

Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merveenoyan merveenoyan merged commit 53052fa into huggingface:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants