-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added CoTracker for download stats #925
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! It LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Would be a good occasion to update CoTracker's GitHub README and HF Model Card to showcase how to load the model from the Hugging Face Hub directly. For now it's showcasing
cotracker = torch.hub.load("facebookresearch/co-tracker", "cotracker2").to(device)
which doesn't use the HF built-in cache system (though it's pulling from HF from what I can see in the hubconf.py)
If that can help, here is a guide on how to download files using huggingface_hub
.
Co-authored-by: Lucain <lucainp@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @lvoursl! I noticed two things to update before merging, otherwise we should be good to go :)
repoName: "CoTracker", | ||
repoUrl: "https://github.com/facebookresearch/co-tracker", | ||
filter: false, | ||
countDownloads: `path_extension:"pt"`, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
countDownloads: `path_extension:"pt"`, | |
countDownloads: `path_extension:"pth"`, |
I just noticed the file extension is not pt
but pth
in https://huggingface.co/facebook/cotracker/tree/main.
@@ -715,6 +715,13 @@ export const MODEL_LIBRARIES_UI_ELEMENTS = { | |||
countDownloads: `path:"model_vae_fp16.pt"`, | |||
snippets: snippets.threedtopia_xl, | |||
}, | |||
cotracker: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you move this entry up in the mapping to keep it consistent with the alphabetical order. Thanks!
@Wauplin I've fixed both things that you mentioned -- looks like good to go :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lvoursl! Everything looks good.
I'll merge this PR now. Expect 2-3 days to see it shipped to production :)
Hey!
Thanks for the amazing library :)
We are hosting CoTracker model checkpoint here and would like to see the download count. This PR follows this one to enable it.
Hope it's correct way to do it, let me know if any changes are needed or there is a better way to do so.