[Tasks] Fix widget model for image-text-to-text task #973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
requested review from
osanseviero,
SBrandeis,
gary149,
Wauplin,
julien-c and
pcuenca
as code owners
pcuenca
reviewed
Oct 18, 2024
There was a problem hiding this comment.
Is it a problem that this model can't be used outside the EU? I think it's fine for serving, just asking out of caution.
Looks good to me otherwise, cc @merveenoyan
|
I think it won't be an issue for serving as you said since it's running through InferenceAPI |
Wauplin
approved these changes
Oct 21, 2024
|
failing tests are unrelated so i guess we can merge this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the widget model for
image-text-to-texttask to putmeta-llama/Llama-3.2-11B-Vision-Instructinstead ofmicrosoft/kosmos-2-patch14-224which is animage-to-textmodel.Also, I'm not sure but this will maybe also fix the widget displayed in the
image-text-to-texttask page.