Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update hf filesystem "get all files" example #2616

Merged
merged 3 commits into from
Oct 23, 2024

Conversation

SwayStar123
Copy link
Contributor

The example is wrong. With the example an error is received
ValueError: Invalid pattern: '**' can only be an entire path component

@SwayStar123
Copy link
Contributor Author

@hanouticelina Can you review this

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@hanouticelina hanouticelina self-requested a review October 22, 2024 16:34
Copy link
Contributor

@hanouticelina hanouticelina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @SwayStar123, thanks for the PR! the correct pattern for recursive matching using HfFileSystem.glob() is indeed **/*.csv :)

@SwayStar123
Copy link
Contributor Author

I cannot merge this, only someone with write access can @hanouticelina

@hanouticelina hanouticelina merged commit aca9aec into huggingface:main Oct 23, 2024
2 checks passed
@SwayStar123 SwayStar123 deleted the patch-1 branch October 23, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants