Update how file's security metadata is retrieved following changes in the API response #2621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanouticelina
changed the title
security key name and BlobSecurityInfo object
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Wauplin
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thanks for adapting this @hanouticelina!
Looks good and should be backward and future-compatible 🤞
cc @coyotte508 @krampstudio for viz'
hanouticelina
added a commit
that referenced
this pull request
Oct 28, 2024
… the API response (#2621) * Update security key name and BlobSecurityInfo object * typos * small typo * add comment * fix typo again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the deployment of huggingface-internal/moon-landing/pull/11077, from now on, the API response of
/{repo_type}s/{repo_id}/tree/{revision}/{path_in_repo}returns the security scan metadata of a file in the fieldsecurityFileStatusinstead ofsecurity. This PR reflects these changes and should fix the failing tests.