Don't write the ref file unless necessary

[d8ahazard]

Updating snapshot_download so that it doesn't re-write the commit hash every single time.

This has been incredibly problematic if we're keeping a repo saved to disk, and snapshot_download can't write to that disk.

This should at least partially resolve the issue.

[Wauplin]

What's the underlying issue you are facing? Is it a permission error? In that case I'd be more inclined to add a try/except instead of additional logic to read before writing (more error-prone)

[d8ahazard]

If the model is on a read-only drive, this will break. My logic fixes that. Ideally, you should probably have both. Only write when you need to, and also wrap it all in a try catch so it doesn't break the whole program if something fails.

…

On Fri, Nov 8, 2024, 3:33 AM Lucain ***@***.***> wrote: What's the underlying issue you are facing? Is it a permission error? In that case I'd be more inclined to add a try/except instead of additional logic to read before writing (more error-prone) — Reply to this email directly, view it on GitHub <#2657 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAMO4NGT6RFB2AS4FHSLQCTZ7SAM3AVCNFSM6AAAAABRL6BTZGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRUGIZTGMBRHA> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[d8ahazard]

What's the underlying issue you are facing? Is it a permission error? In that case I'd be more inclined to add a try/except instead of additional logic to read before writing (more error-prone)

See my additional commit - I added exception handling for both parts of dealing with the ref file.

[Wauplin]

Thanks @d8ahazard!

[HuggingFaceDocBuilderDev]

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

[d8ahazard]

Thanks @d8ahazard!

Thank you! You have no idea how many headaches this is going to solve for me. ;)