[Bot] Update inference types #2664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
8149425 to
7b3624a
Compare
|
(generated as part of #2600, let's not merge yet) |
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
7b3624a to
15d8612
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
690decf to
05df70f
Compare
…ingface/huggingface_hub into update-inference-types-automated-pr
hanouticelina
approved these changes
Nov 21, 2024
Comment on lines
17
to
18
| """Additional inference parameters | ||
| Additional inference parameters for Text Classification |
There was a problem hiding this comment.
(nit) the duplicate docstring comes from huggingface/huggingface.js/tasks/text-classification/spec/input.json#L13 and huggingface/huggingface.js/tasks/text-classification/spec/input.json#L20, same for other tasks.
There was a problem hiding this comment.
Let's remove it then (we can still merge this PR first)
There was a problem hiding this comment.
"parameters": {
"$ref": "#/$defs/TextClassificationParameters"
}
seems enough
There was a problem hiding this comment.
i'm opening a PR now to remove it!
hanouticelina
added a commit
to huggingface/huggingface.js
that referenced
this pull request
Nov 21, 2024
this PR removes redundant description in task parameter classes definition while keeping it in the parameters field reference. this avoids duplicate documentation, see: [huggingface/huggingface_hub/pull/2664#discussion](huggingface/huggingface_hub#2664 (comment)) for more context. Note : `packages/tasks/src/tasks/{task_name/inference.ts` files are auto-generated.
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
d274efb to
a6e1cd2
Compare
…ingface/huggingface_hub into update-inference-types-automated-pr
hanouticelina
approved these changes
Nov 22, 2024
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
c63d566 to
b8c5b97
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
b8c5b97 to
911c175
Compare
…ingface/huggingface_hub into update-inference-types-automated-pr
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
911c175 to
9b5de39
Compare
HuggingFaceInfra
force-pushed
the
update-inference-types-automated-pr
branch
from
9b5de39 to
08d3f65
Compare
…ingface/huggingface_hub into update-inference-types-automated-pr
|
the CI is finally 💚 let's merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the inference types. It has been generated by running:
This PR was automatically created by the Update Inference Types workflow.
Make sure the changes are correct before merging.