More refactoring #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…notron into nouamane/refactor-2
Useful scripts
3outeille
reviewed
Jan 30, 2024
| @@ -11,6 +9,7 @@ | |||
| from nanotron.core.parallelism.pipeline_parallelism.p2p import P2P, BatchTensorSendRecvState | |||
| from nanotron.core.parallelism.pipeline_parallelism.state import PipelineBatchState, PipelineTrainBatchState | |||
| from nanotron.core.parallelism.pipeline_parallelism.tensor_pointer import TensorPointer | |||
| from torch import nn | |||
There was a problem hiding this comment.
some files has torch_nn and other nn. Should we just use torch_nn in every file ?
xrsrke
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same as #2 so will merge