-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Transformers 4.43 #1163
Merged
Merged
Changes from all commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
1390282
Update examples
regisss 60d2a5a
Add changes for generate
regisss e06c663
Model changes
regisss ace3e10
Make style
regisss 3b15d6d
Upgrade Accelerate
regisss f85ce43
Fix setup.py
regisss 49d8774
Fixes
regisss 7cf0f0a
Merge branch 'main' into transformers_4.43
regisss 3a0be9f
Model fixes
regisss 4cf3dbb
Fix FSDP
regisss 0cbb67c
Other model fixes
regisss c5418b3
Merge branch 'main' into transformers_4.43
regisss 820eb7d
Model fixes
regisss 826b666
Merge branch 'main' into transformers_4.43
regisss 2e8a80d
Merge branch 'main' into transformers_4.43
regisss 4261160
Add support for contrastive search (#943)
skavulya c2fe976
Add sample and beam-sample to bucketting asserts
regisss 6efef09
Merge branch 'main' into transformers_4.43
regisss 55f9b0c
Fix max_position_embedding init for tf4.43 upgrade (#1202)
jiminha 30918d4
Merge branch 'main' into transformers_4.43
regisss 52ba812
Merge branch 'main' into transformers_4.43
regisss a004253
Hsub 443 integ (#1204)
regisss 3fce38c
Fix LlamaConfig attr errors during test (#1206)
shepark 66e2063
Fix max_position_embedding error for Mixtral (#1205)
jiminha 2c1a68d
Sarkar/transformers 4.43 fixes part2 (#1207)
ssarkar2 7c96602
Revert "Fix max_position_embedding init for tf4.43 upgrade (#1202)" (…
jiminha 8ebd789
Fix diffusers. From PR 1208 (#1210)
ssarkar2 76cfa0b
fea(): fixed pytest errors for gptneox (#1212)
imangohari1 74611d9
Sarkar/transformers 4.43 fixes for gpt2 test_torch_fx (#1213)
ssarkar2 29c6f57
fea(937): fixes related to OSError (#1214)
imangohari1 374369e
Starcoder2 : KVCache and flash attention (FusedSDPA) enablement (#1149)
abhatkal d3e3b3c
Align StarCoder2 with Transformers 4.43
regisss ee46bed
Merge branch 'main' into transformers_4.43
regisss 24ba6f0
Update GPT-NeoX
regisss File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -4,4 +4,4 @@ sentencepiece != 0.1.92 | |
protobuf | ||
evaluate | ||
scikit-learn | ||
peft == 0.10.0 | ||
peft == 0.12.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, I am trying to run this test with versions (optimum-habana==1.12.1, transformers==4.43.0) but encountered the following error:
I also tried with optimum-habana version 1.12.0 and encountered the same error.
Can someone please point me to the correction PR or if there is any documentation to fix this?
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should pip install optimimum habana from git, because this fork is ahead of 1.12.1, and have different dependencies, and this should be listed as 1.13.0.dev as the version number.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it should be
check_optimum_habana_min_version("1.13.0.dev0")
, I'll add a script to do that automatically.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, Thanks for the info. So, currently, I am using
pip install git+https://github.com/huggingface/optimum-habana.git@{{ optimum_habana_version }}
. Would usingpip install git+https://github.com/huggingface/optimum-habana.git
to use the latest version that is compatible with transformers==4.43.0 work for future transformers versions?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It may not work with future Transformers versions as there might be changes that are not compatible with what we do here in Optimum Habana.
In the coming weeks, I will open a new branch and try to maintain it so that new Transformers releases are supported but with potential perf regressions (which will be solved once it comes to the main branch).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @regisss, that would be helpful.
Until then, I will be using transformers==4.43.0 while doing
pip install git+https://github.com/huggingface/optimum-habana.git
. It worked for me yesterday without specifying the optimum-habana version.Can you please confirm if this^ would continue working for 4.43.0 only, please?
For future transformers' version - I'll be keep an eye out for the new branch you mentioned.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the main branch should work for Transformers 4.43.x till the next time we align the lib with a new version of Transformers.