Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vera/ln_tuning add and test case add #1294

Merged
merged 5 commits into from
Sep 25, 2024
Merged

vera/ln_tuning add and test case add #1294

merged 5 commits into from
Sep 25, 2024

Conversation

sywangyi
Copy link
Collaborator

What does this PR do?

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sywangyi
vera/ln_tuning add and test case add
a5d8ddc 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@sywangyi sywangyi requested a review from regisss as a code owner August 28, 2024 08:07
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@sywangyi
skip some peft test for falcon
e781e09 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@libinta libinta added run-test Run CI for PRs from external contributors labels Sep 18, 2024
regisss
regisss reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@regisss regisss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a rule in

optimum-habana/tests/test_examples.py

Line 281 in 8263a4f

elif "ast-finetuned-speech-commands-v2" in model_name and IS_GAUDI2:
to make sure these tests are not executed on Gaudi1.

examples/language-modeling/README.md Outdated Show resolved Hide resolved
sywangyi and others added 3 commits September 25, 2024 20:53
@sywangyi @regisss
Apply suggestions from code review
644d654 
Co-authored-by: regisss <15324346+regisss@users.noreply.github.com>
@sywangyi
Merge branch 'main' into peft_ln_vera
6e51f16
@sywangyi
skip some test in Gaudi1
a2a10bb 
Signed-off-by: Wang, Yi A <yi.a.wang@intel.com>
@regisss regisss merged commit 1f5231e into main Sep 25, 2024
6 of 7 checks passed
@regisss regisss deleted the peft_ln_vera branch September 25, 2024 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsubramony hsubramony hsubramony approved these changes

@regisss regisss regisss approved these changes

Assignees
No one assigned
Labels
run-test Run CI for PRs from external contributors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sywangyi @HuggingFaceDocBuilderDev @regisss @hsubramony @libinta