Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch failed code quality check comment to workflow_run #1297

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

regisss
Copy link
Collaborator

@regisss regisss commented Aug 29, 2024

What does this PR do?

The workflow used for posting a comment when the code quality check failed is currently a workflow_call, which doesn't have more permissions than the caller workflow (i.e. pull_request) and thus cannot post a comment in a PR from a fork.
This PR updates this workflow switching to workflow_run to fix that.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@regisss regisss merged commit d9c28e0 into main Aug 29, 2024
7 checks passed
@regisss regisss deleted the fix_code_style_workflow branch August 29, 2024 16:52
atakaha pushed a commit to atakaha/optimum-habana that referenced this pull request Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants