-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement MPNet model #363
base: main
Are you sure you want to change the base?
Conversation
Unable to run on Metal local install:
I can try taking a crack at this if desired |
thanks for checking in. that sounds great! I’d really appreciate your input. please feel free to dive in whenever you are available :) |
I just made a small change not to support the Metal devices temporarily 13ebffb |
Thank you :) will check into this. Sorry I have been too busy to look into this lately |
no worries! take your time :) if you need any help, please feel free to mention me here |
@ramipellumbi I just made a commit to fix that Metal issue! -> 9b58292 @OlivierDehaene I guess this PR is ready to review
|
@OlivierDehaene would it be possible to get this PR merged? |
What does this PR do?
Fixes #250
Fixes #33
feedback or contributions are welcome!
MPNetAttentionBias
MPNetAttention
is now identical to the Python implementation.Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@OlivierDehaene OR @Narsil