Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Environment Variable for OTLP Service Name #2069

Closed
KevinDuffy94 opened this issue Jun 14, 2024 · 3 comments
Closed

Add Environment Variable for OTLP Service Name #2069

KevinDuffy94 opened this issue Jun 14, 2024 · 3 comments
Labels

Comments

@KevinDuffy94
Copy link
Contributor

KevinDuffy94 commented Jun 14, 2024

Feature request

Currently the Service Name for OTLP is hard-coded as "text-generation-inference.server"
Could an environment variable be added which could set this. Something like...

resource = Resource.create( attributes={"service.name": os.getenv("OTLP_SERVICE_NAME","text-embeddings-inference.server")} )

And similar in the main.rs file in the router.

Motivation

Currently I have multiple models deployed and will be collected into a single APM so this will be problematic.

Your contribution

Unconfident in writing any rust code.

@LysandreJik
Copy link
Member

WDYT @OlivierDehaene? Are you open for this addition?

@LysandreJik
Copy link
Member

Seen with Olivier, sounds good! Would you like to open a PR similarly to huggingface/text-embeddings-inference#285?

KevinDuffy94 added a commit to KevinDuffy94/text-generation-inference that referenced this issue Jun 17, 2024
Narsil pushed a commit that referenced this issue Jun 25, 2024
* Adding Service Name Environment variable for #2069

* Update Docs

* Update README.md

* Update Launcher Docs

* Update Launcher Docs
Removing Option
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 5 days.

@github-actions github-actions bot added the Stale label Jul 18, 2024
@Hugoch Hugoch closed this as completed Jul 18, 2024
yuanwu2017 pushed a commit to yuanwu2017/tgi-gaudi that referenced this issue Sep 26, 2024
* Adding Service Name Environment variable for huggingface#2069

* Update Docs

* Update README.md

* Update Launcher Docs

* Update Launcher Docs
Removing Option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants