Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding max_token_capacity metric #2279

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Edwinhr716
Copy link

What does this PR do?

Emit max_batch_total_tokens as max_token_capacity as part of metrics standardization

Fixes # (issue)

Before submitting

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.

@Edwinhr716 Edwinhr716 changed the title adding max_token_capacity_metric adding max_token_capacity metric Jul 22, 2024
@achandrasekar
Copy link

@Narsil can you take a look at this one?

@achandrasekar
Copy link

I wanted to ping on this. There is already a tgi_batch_current_max_tokens metric which reports the current batch size in terms of tokens. Adding this max_token_capacity alongside would allow us to see how far off from the max capacity we are at and helps us with autoscaling proactively where we can say we are at 75% capacity and trigger a scale up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants