refactor: improve error handling in copyTo method

hughfenghen · Dec 19, 2024 · 1186860 · 1186860
1 parent b4bd4b5
commit 1186860
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/.changeset/fair-radios-wait.md b/.changeset/fair-radios-wait.md
@@ -0,0 +1,5 @@
+---
+'opfs-tools': patch
+---
+
+refactor: improve error handling in copyTo method
diff --git a/src/file.ts b/src/file.ts
@@ -287,16 +287,15 @@ export class OPFSFileWrap {
    * if the target is a folder, copy the current file into that folder.
    */
   async copyTo(target: OPFSDirWrap | OPFSFileWrap): Promise<OPFSFileWrap> {
-    if (!(await this.exists())) {
-      throw Error(`file ${this.path} not exists`);
-    }
-
     if (target instanceof OPFSFileWrap) {
-      if (file(target.path) === this) return this;
+      if (target.path === this.path) return this;
 
       await write(target.path, this);
       return file(target.path);
     } else if (target instanceof OPFSDirWrap) {
+      if (!(await this.exists())) {
+        throw Error(`file ${this.path} not exists`);
+      }
       return await this.copyTo(file(joinPath(target.path, this.name)));
     }
     throw Error('Illegal target type');