Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-114277: Add return types to sqlite methods in docs #59

Merged
merged 27 commits into from
Jan 19, 2024

Conversation

ryan-duve
Copy link

@ryan-duve ryan-duve commented Jan 19, 2024

Resolves #114277

Add structured return types for methods in the sqlite3 module.


📚 Documentation preview 📚: https://hugovk-cpython--59.org.readthedocs.build/en/59/

erlend-aasland and others added 27 commits January 17, 2024 17:25
Instead of checking if a directory does not exist and thereafter
creating it, directly call os.makedirs() with the exist_ok=True.
)

Only set filename to cwd if it was caused by failed chdir(cwd).

_fork_exec() now returns "noexec:chdir" for failed chdir(cwd).

Co-authored-by: Robert O'Shea <PurityLake@users.noreply.github.com>
… threadpools (python#114186)

pythongh-113205: test_multiprocessing.test_terminate: Test the API works on threadpools

Threads can't be forced to terminate (without potentially corrupting too much
state), so the  expected behaviour of `ThreadPool.terminate` is to wait for
the currently executing tasks to finish.

The entire test was skipped in pythonGH-110848 (0e9c364).
Instead of skipping it entirely, we should ensure the API eventually succeeds:
use a shorter timeout.

For the record: on my machine, when the test is un-skipped, the task manages to
start in about 1.5% cases.
…bject' (python#114227)

Prefix 'dict' with 'o', 'g', or 'l' for 'object', 'global', or 'local'.
Suffix 'object' with '_'.
… root home directory (pythonGH-114236)

* pythongh-104522: Fix test_subprocess failure when build Python in the root home directory

EPERM is raised when setreuid() fails.
EACCES is set in execve() when the test user has not access to sys.executable.
… int() (pythonGH-114067)

Co-authored-by: Kirill Podoprigora <kirill.bast9@mail.ru>
…onGH-113620)


Co-authored-by: Erlend E. Aasland <erlend@python.org>
…t/test_doctest/` (python#112109)

Co-authored-by: Brett Cannon <brett@python.org>
…hongh-114251)

This change renames the dataclass __replace__ method's first argument
name from 'obj' to 'self'.
…hon#112093)

Use different versions in the examples for when extensions do and do not need to be recompiled to make the examples easier to understand.
Co-authored-by: Adam Turner <9087854+AA-Turner@users.noreply.github.com>
Co-authored-by: Éric <merwok@netwok.org>
@hugovk hugovk merged commit a34e4db into hugovk:main Jan 19, 2024
37 of 43 checks passed
@hugovk
Copy link
Owner

hugovk commented Jan 19, 2024

Hmm, this was a PR of your main branch to mine, and when I updated my main to match upstream, GitHub automatically closed this because they were the same.

Please make a PR from this branch:

https://github.com/ryan-duve/cpython/tree/fix-issue-114277

You can do it from this link:

main...ryan-duve:cpython:fix-issue-114277

@ryan-duve
Copy link
Author

Attempt 3: #60

@hugovk
Copy link
Owner

hugovk commented Jan 19, 2024

Perfect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add return types to methods in documentation