Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ctf] Change the min and default weight value to 1 to match ctftime value #100

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[ctf] Change the min and default weight value to 1 to match ctftime value #100

wants to merge 1 commit into from

Conversation

ValekoZ
Copy link

@ValekoZ ValekoZ commented May 30, 2024

On ctftime the default and min weight are 0, but this was 1 on ctfhub, which made it impossible to import some ctfs from ctftime

hugsy
hugsy reviewed Jun 1, 2024
View reviewed changes
Copy link
Owner

@hugsy hugsy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch and LGTM. Also you're missing a migration here because you're changing the model.

ctfhub/models.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hugsy hugsy hugsy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ValekoZ @hugsy