Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative Update to ROS 1 Melodic #6

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mabelzhang
Copy link

This is an alternative to #4 to update to ROS 1 Melodic. We made quite a bit of changes, but we believe these changes make the package cleaner and update it to standard practice in ROS 1.

Changes we made:

  • ROS-packagify drivers/C into hri_c_driver, to eliminate the duplicate C files that exist in both drivers/C and hri_safety_sense directories. We tested that the C tutorials still compile and run using the pure Makefile, if the user does not wish to use ROS.
  • Move header files in drivers/C into include/<package_name> subdirectory, which is standard ROS practice
  • Clean up README files
  • Fix warning about comparing unsigned int with -1
  • Remove unnecessary files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant