NIOAsyncChannel based HTTP server #269

adam-fowler · 2023-11-07T09:55:01Z

HTTP server using NIOAsyncChannel. This requires a bunch a changes. I'll update this PR as they are done

Sources/HummingbirdCore/Server/HTTP/HTTPChannelSetup.swift

- Use a taskGroup so we can wait for write to finish before starting new read - Make sure we flush the request body always

codecov · 2023-11-07T16:59:58Z

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (d2403d1) 83.87% compared to head (1d5c5f9) 85.12%.
Report is 1 commits behind head on 2.x.x.

Files	Patch %	Lines
Sources/HummingbirdCore/Server/Server.swift	84.69%	30 Missing ⚠️
...mmingbirdCore/Server/HTTP/HTTPChannelHandler.swift	92.00%	6 Missing ⚠️
Sources/HummingbirdCore/Request/RequestBody.swift	88.00%	3 Missing ⚠️
.../HummingbirdCore/Server/HTTPUserEventHandler.swift	95.38%	3 Missing ⚠️
...ources/Hummingbird/Middleware/CORSMiddleware.swift	66.66%	1 Missing ⚠️
Sources/Hummingbird/Router/ResponseGenerator.swift	80.00%	1 Missing ⚠️
...ources/HummingbirdCore/Response/HTTPResponse.swift	85.71%	1 Missing ⚠️
...ces/HummingbirdCore/Server/HTTP/HTTP1Channel.swift	96.15%	1 Missing ⚠️
Sources/HummingbirdTLS/TLSChannelSetup.swift	96.66%	1 Missing ⚠️
Sources/HummingbirdXCT/HBXCTRouter.swift	97.36%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            2.x.x     #269      +/-   ##
==========================================
+ Coverage   83.87%   85.12%   +1.25%     
==========================================
  Files          83       78       -5     
  Lines        5301     4565     -736     
==========================================
- Hits         4446     3886     -560     
+ Misses        855      679     -176

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Don't want to encourage people to use AsyncStream while it doesn't provide back pressure

adam-fowler · 2023-11-08T16:42:37Z

There's something wrong with the core server. Its performance is really poor on Linux

.github/workflows/ci.yml

Sources/Hummingbird/Middleware/CORSMiddleware.swift

Sources/Hummingbird/Server/Application+HTTPResponder.swift

Sources/Hummingbird/Server/RequestContext.swift

Sources/HummingbirdCore/Server/HTTPUserEventHandler.swift

* Use new NIOAsyncChannel.executeThenClose api * fix tabbing

Joannis

One small comment I just noticed

Joannis · 2023-11-17T19:47:45Z

Sources/PerformanceTest/main.swift

@@ -21,7 +21,7 @@ let hostname = HBEnvironment.shared.get("SERVER_HOSTNAME") ?? "127.0.0.1"
 let port = HBEnvironment.shared.get("SERVER_PORT", as: Int.self) ?? 8080

 // create app
-let elg = MultiThreadedEventLoopGroup(numberOfThreads: 2)
+let elg = MultiThreadedEventLoopGroup(numberOfThreads: 8)


Can we use System.coreCount here instead?

Or NIOSingletons.posixEventLoopGroup

I wanted to use a set number here, which doesn't use all the machines cores. I tend to use this with wrk for performance testing. I need to assign some cores to wrk otherwise it'll clash with the server and results will be inconsistent.

Although that number should be 4 and not 8. Performance seems to top out at 4 cores on macOS for some reason. Possibly related to the limited number of connections you can make on macOS.

adam-fowler marked this pull request as draft November 7, 2023 09:55

adam-fowler force-pushed the async-http-server branch from b78c6a6 to 6a14e21 Compare November 7, 2023 10:10

Joannis reviewed Nov 7, 2023

View reviewed changes

Sources/HummingbirdCore/Server/HTTP/HTTPChannelSetup.swift Outdated Show resolved Hide resolved

Sources/HummingbirdCore/Server/HTTP/HTTPChannelSetup.swift Outdated Show resolved Hide resolved

adam-fowler added 11 commits November 7, 2023 13:24

Swift concurrency based HTTP server

d3eaf0c

Delete unused code

2df8d36

Make sure we don't hang on cancellation

ce16723

- Use a taskGroup so we can wait for write to finish before starting new read - Make sure we flush the request body always

Set correct HTTP version

ff06c70

Moving stuff about, Get TLS working

b891789

Fixed tests not reporting errors, Transport service working

a682e8e

Hummingbird compiles

e0b1874

HBRequestBody that can be both stream and buffer

efe5afa

Start hummingbird-foundation fixup

881598a

hummingbird-foundation compiling

861ba50

PerformanceTest working

0c0da63

adam-fowler force-pushed the async-http-server branch from 0dc5ba2 to 0c0da63 Compare November 7, 2023 13:53

adam-fowler added 4 commits November 7, 2023 15:50

Hummingbird tests working

95be94a

HummingbirdFoundation tests working

657a10f

Transport services TLS

e5f19a9

Remove swift versions that don't work

8e0a4bd

adam-fowler added 8 commits November 7, 2023 17:00

Remove old hummingbird-core files

188a8ea

Added logger output when read/write fails because of channel close

cb300ab

Add support for setting channelSetup

ab9d64f

Add test for editing response body in middleware

d06abf6

Remove AsyncStream HBResponseGenerator conformance

e3518cc

Don't want to encourage people to use AsyncStream while it doesn't provide back pressure

Fixed minor bug in HBHTTPUserEventHandler

e9ab11b

Remove TimeoutPromise

1685270

Remove pre macOS13 dateCache implementation

f840a96

adam-fowler marked this pull request as ready for review November 8, 2023 08:49

Add write, read idle handler tests

c110d84

Clear out unused config vars

008cf72

HTTPChannelHandler

15ccb56

Joannis reviewed Nov 8, 2023

View reviewed changes

adam-fowler added 4 commits November 9, 2023 08:13

Comments from PR

e3a93a5

Don't writeAndFlush everything

93c90eb

Remove tcpNoDelay, and withPipelineAssistance from configuration

6a6d718

Up number of eventloops in example

9e754f7

Joannis approved these changes Nov 16, 2023

View reviewed changes

Don't assume child channel returns a NIOAsyncChannel (#272)

f48ea56

Joannis force-pushed the async-http-server branch from 08a6e60 to f48ea56 Compare November 17, 2023 16:05

Use new NIOAsyncChannel.executeThenClose API (#277)

5fd3cdd

* Use new NIOAsyncChannel.executeThenClose api * fix tabbing

Joannis reviewed Nov 17, 2023

View reviewed changes

Update EventLoopGroup size

1d5c5f9

adam-fowler merged commit 94e433e into 2.x.x Nov 18, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

NIOAsyncChannel based HTTP server #269

NIOAsyncChannel based HTTP server #269

adam-fowler commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading

adam-fowler commented Nov 8, 2023

Joannis left a comment

Joannis Nov 17, 2023

Joannis Nov 17, 2023

Joannis Nov 17, 2023

adam-fowler Nov 18, 2023

NIOAsyncChannel based HTTP server #269

NIOAsyncChannel based HTTP server #269

Conversation

adam-fowler commented Nov 7, 2023 • edited Loading

codecov bot commented Nov 7, 2023 • edited Loading

Codecov Report

adam-fowler commented Nov 8, 2023

Joannis left a comment

Choose a reason for hiding this comment

Joannis Nov 17, 2023

Choose a reason for hiding this comment

Joannis Nov 17, 2023

Choose a reason for hiding this comment

Joannis Nov 17, 2023

Choose a reason for hiding this comment

adam-fowler Nov 18, 2023

Choose a reason for hiding this comment

adam-fowler commented Nov 7, 2023 •

edited

Loading

codecov bot commented Nov 7, 2023 •

edited

Loading