Swift HTTP Types #288
Swift HTTP Types #288
Conversation
| attributes["http.scheme"] = request.uri.scheme?.rawValue | ||
| attributes["http.user_agent"] = request.headers.first(name: "user-agent") | ||
| attributes["http.request_content_length"] = request.headers["content-length"].first.map { Int($0) } ?? nil | ||
| // TODO: Get HTTP version and scheme |
There was a problem hiding this comment.
We never setup the scheme before, it always defaulted to nil. The swift http types don't include a version so not sure how we are going to get that
Package.swift
Outdated
| // .library(name: "HummingbirdFoundation", targets: ["HummingbirdFoundation"]), | ||
| // .library(name: "HummingbirdJobs", targets: ["HummingbirdJobs"]), | ||
| // .library(name: "HummingbirdXCT", targets: ["HummingbirdXCT"]), | ||
| // .executable(name: "PerformanceTest", targets: ["PerformanceTest"]), |
There was a problem hiding this comment.
Any particular reason for lal these disabled products?
Package.swift
Outdated
| @@ -7,17 +7,19 @@ let package = Package( | |||
| name: "hummingbird", | |||
| platforms: [.macOS(.v14), .iOS(.v17), .tvOS(.v17)], | |||
| products: [ | |||
| .library(name: "Hummingbird", targets: ["Hummingbird"]), | |||
| // .library(name: "Hummingbird", targets: ["Hummingbird"]), | |||
|
What's changed looks good, but we have disabled some products. Can we get those back up & running? |
I must have disabled them as I was getting stuff compiling. |
adam-fowler
force-pushed
the
http-types
branch
from
744cc33 to
c280749
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #288 +/- ##
==========================================
- Coverage 84.97% 84.85% -0.13%
==========================================
Files 78 77 -1
Lines 4520 4515 -5
==========================================
- Hits 3841 3831 -10
- Misses 679 684 +5 ☔ View full report in Codecov by Sentry. |
No description provided.