Remove Application Context #308
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #308 +/- ##
==========================================
- Coverage 84.78% 84.55% -0.24%
==========================================
Files 79 79
Lines 4543 4525 -18
==========================================
- Hits 3852 3826 -26
- Misses 691 699 +8 ☔ View full report in Codecov by Sentry. |
| /// are being recorded. | ||
| public init(recordingHeaders headerNamesToRecord: some Collection<HTTPField.Name>) { | ||
| public init(recordingHeaders headerNamesToRecord: some Collection<HTTPField.Name> = [], attributes: SpanAttributes? = nil) { |
There was a problem hiding this comment.
I assume this is not related to the application context change
There was a problem hiding this comment.
This is related, in that when we remove the application context we don't have access to some of the application configuration, so cannot update some attributes eg "net.host.name" and "net.host.port". My solution was to allow the user to add some static attributes to the middleware itself.
adam-fowler
force-pushed
the
remove-application-context
branch
from
6968f7e to
2d9f89a
Compare
|
Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2023-12-15T08:51:36+00:00 |
Remove application context from request context