Benchmarks 2.x #309
Merged
Benchmarks 2.x #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #309 +/- ##
=======================================
Coverage 84.78% 84.78%
=======================================
Files 79 79
Lines 4543 4543
=======================================
Hits 3852 3852
Misses 691 691 ☔ View full report in Codecov by Sentry. |
Joannis
approved these changes
Dec 14, 2023
| trieRouterBenchmarks() | ||
| routerBenchmarks() | ||
| // The HTTP benchmarks are so variable I'm not sure they are worthwhile running | ||
| //http1Benchmarks() |
There was a problem hiding this comment.
Any idea why they're so diverse?
There was a problem hiding this comment.
I don't know if it is a timing issue causing more allocations. I would prefer if we could get these more stable as they test the whole pipeline more thoroughly
adam-fowler
force-pushed
the
benchmarks-2.x
branch
from
cc2dcac to
32dd839
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmarks for HB 2.x
First run of this will fail as the benchmark code on 2.x.x branch is out of date. This needs to be merged before we see the benchmark CI working.