HBRouteHandler cleanup

[adam-fowler]

• handle method only gets the context as it is assumed you have extracted all you need from the request in init
• Removed HBRequestDecodable as soon as that was released I hated it.
• correct comment

Not sure if I'll keep the route handlers as it is hard to do dependency injection with them. But for the moment I've cleaned up everything a little

I also changed HBRequest.decode(as:using) to HBRequest.decode(as:context). I don't use using to pass the context around anyway else. It is always context. This change went in here as it clashed with the rest of this PR

[codecov]

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (48371bc) 83.13% compared to head (ddc3243) 83.10%.

Files	Patch %	Lines
Sources/Hummingbird/Router/RouteHandler.swift	66.66%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##            2.x.x     #332      +/-   ##
==========================================
- Coverage   83.13%   83.10%   -0.04%     
==========================================
  Files          92       91       -1     
  Lines        5009     5006       -3     
==========================================
- Hits         4164     4160       -4     
- Misses        845      846       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2024-01-05T16:30:32+00:00
Pull request had performance regressions

[Joannis]

@adam-fowler I like removing HBRequestDecodable, and understand removing the request from handle. But since init also gets the context, shouldn't we remove that from handle as well?

[adam-fowler]

@adam-fowler I like removing HBRequestDecodable, and understand removing the request from handle. But since init also gets the context, shouldn't we remove that from handle as well?

Then people would have to store things like the logger and allocator in the route handler

[Joannis]

I'm not sure what to think of the remaining issue I've brought up, but this improvement is already a welcome one. Should we make an discussion topic/issue of my comment?

[adam-fowler]

I'm not sure what to think of the remaining issue I've brought up, but this improvement is already a welcome one. Should we make a discussion topic/issue of my comment?

Yeah add an issue