2.x.x - Don't shutdown server in HBApplication #337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The service group will do that for us
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #337 +/- ##
==========================================
- Coverage 83.09% 83.07% -0.03%
==========================================
Files 92 92
Lines 5022 5016 -6
==========================================
- Hits 4173 4167 -6
Misses 849 849 ☔ View full report in Codecov by Sentry. |
|
Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2024-01-07T21:34:08+00:00 |
Joannis
reviewed
Jan 7, 2024
The server should be last as it should be the first service to shutdown
adam-fowler
changed the title
Joannis
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The service group will do that for us