Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x.x - Don't shutdown server in HBApplication #337

Merged
merged 4 commits into from
Jan 11, 2024
Merged

2.x.x - Don't shutdown server in HBApplication #337

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8b62fcb
Don't shutdown server in HBApplication
adam-fowler Jan 7, 2024
1b8cd8a
Disable conditionalAssignment swiftformat rule
adam-fowler Jan 7, 2024
9774669
Remove graceful shutdown handler surrounding HBApplicationProtocol.run
adam-fowler Jan 7, 2024
a80321d
Fix ordering of services
adam-fowler Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .swiftformat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
--exclude .build

# rules
--disable redundantReturn, extensionAccessControl
--disable redundantReturn, extensionAccessControl, conditionalAssignment

# format options
--ifdef no-indent
Expand Down
6 changes: 1 addition & 5 deletions Sources/Hummingbird/Application.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,7 @@ extension HBApplicationProtocol {
configuration: .init(services: services, logger: self.logger)
)
try await serviceGroup.run()
} onGracefulShutdown: {
Task {
try await server.shutdownGracefully()
}
}
} onGracefulShutdown: {}
adam-fowler marked this conversation as resolved.
Show resolved Hide resolved
}

/// Helper function that runs application inside a ServiceGroup which will gracefully
Expand Down
Loading