Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make HBBindAddress a struct #361

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Make HBBindAddress a struct #361

merged 1 commit into from
Jan 26, 2024

Conversation

adam-fowler
Copy link
Member

No description provided.

@adam-fowler adam-fowler requested a review from Joannis January 25, 2024 17:05
Copy link

codecov bot commented Jan 25, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1e4ccb1) 83.72% compared to head (09ef8c2) 83.91%.

Files Patch % Lines
Sources/HummingbirdCore/Server/BindAddress.swift 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #361      +/-   ##
==========================================
+ Coverage   83.72%   83.91%   +0.19%     
==========================================
  Files          91       91              
  Lines        5043     5036       -7     
==========================================
+ Hits         4222     4226       +4     
+ Misses        821      810      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

guard case .hostname(_, let port) = self else { return nil }
return port
public struct HBBindAddress: Sendable, Equatable {
enum _Internal: Equatable {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always a fan of this pattern.

@adam-fowler adam-fowler merged commit 2f69954 into 2.x.x Jan 26, 2024
3 of 5 checks passed
@adam-fowler adam-fowler deleted the 2.x.x-struct-bind-address branch January 26, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants