-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x.x - Generalized Client #364
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## 2.x.x #364 +/- ##
==========================================
+ Coverage 83.99% 84.08% +0.09%
==========================================
Files 91 93 +2
Lines 5022 5095 +73
==========================================
+ Hits 4218 4284 +66
- Misses 804 811 +7 ☔ View full report in Codecov by Sentry. |
Pull request benchmark comparison [ubuntu-latest] with '2.x.x' run at 2024-01-27T16:33:58+00:00 |
5129278
to
a18364b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
HBClient
which takes aHBClientChannel
to setup the channel.HBClientChannel
differs slightly fromHBChildChannel
in that its handle function can throw errorsHBBindAddress
toHBAddress
HBClient
.