Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.x.x - Generalized Client #364

Merged
merged 9 commits into from
Jan 29, 2024
Merged

2.x.x - Generalized Client #364

merged 9 commits into from
Jan 29, 2024

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Jan 27, 2024

  • Added HBClient which takes a HBClientChannel to setup the channel.
  • HBClientChannel differs slightly from HBChildChannel in that its handle function can throw errors
  • Rename HBBindAddress to HBAddress
  • Cleanup TLS test code, so the getClientTLSConfiguration and getServerTLSConfiguration are in one place
  • Added tests for basic HTTP client using HBClient.
  • Extended TSTLSOptions to support clients as well

Copy link

codecov bot commented Jan 27, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (3666669) 83.99% compared to head (3333b3d) 84.08%.

Files Patch % Lines
Sources/HummingbirdCore/Client/Client.swift 85.96% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #364      +/-   ##
==========================================
+ Coverage   83.99%   84.08%   +0.09%     
==========================================
  Files          91       93       +2     
  Lines        5022     5095      +73     
==========================================
+ Hits         4218     4284      +66     
- Misses        804      811       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Jan 27, 2024

@adam-fowler adam-fowler requested a review from Joannis January 27, 2024 16:53
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adam-fowler adam-fowler merged commit fc15dc5 into 2.x.x Jan 29, 2024
4 of 5 checks passed
@adam-fowler adam-fowler deleted the 2.x.x-client branch January 29, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants