Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run processesRunBeforeServerStart after ServiceGroup in router XCT framework #374

Merged
merged 2 commits into from
Feb 5, 2024

Conversation

adam-fowler
Copy link
Member

No description provided.

@adam-fowler adam-fowler requested a review from Joannis February 5, 2024 13:50
Copy link

codecov bot commented Feb 5, 2024

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (4a2a119) 84.07% compared to head (9b456ae) 84.01%.

Files Patch % Lines
Sources/HummingbirdXCT/HBXCTRouter.swift 33.33% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #374      +/-   ##
==========================================
- Coverage   84.07%   84.01%   -0.07%     
==========================================
  Files          93       93              
  Lines        5099     5104       +5     
==========================================
+ Hits         4287     4288       +1     
- Misses        812      816       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler requested a review from Joannis February 5, 2024 15:15
@adam-fowler adam-fowler merged commit 6a678c9 into 2.x.x Feb 5, 2024
2 of 4 checks passed
@adam-fowler adam-fowler deleted the 2.x.x-xctrouter-services branch February 5, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants