Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HBFileIO changes #390

Closed
wants to merge 3 commits into from
Closed

HBFileIO changes #390

wants to merge 3 commits into from

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Feb 20, 2024

  • Added makeDirectory
  • writeFile can be used to write arbitrary buffers, or sequences of buffers
  • Don't return size from loadFile as it is already available in returned response body

@adam-fowler adam-fowler requested a review from Joannis February 20, 2024 09:17
Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

Comparison is base (0b33c97) 84.51% compared to head (0573d21) 84.17%.
Report is 8 commits behind head on 2.x.x.

Files Patch % Lines
Sources/Hummingbird/Files/FileIO.swift 22.22% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            2.x.x     #390      +/-   ##
==========================================
- Coverage   84.51%   84.17%   -0.34%     
==========================================
  Files          95       94       -1     
  Lines        5283     5296      +13     
==========================================
- Hits         4465     4458       -7     
- Misses        818      838      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adam-fowler adam-fowler deleted the 2.x.x-file-extensions branch June 14, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant