Use generic for file loading in FileMiddleware #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow for writing custom file loaders that cache file contents or use another source than the local file system for files
Joannis
reviewed
Mar 19, 2024
| size: numericCast(lstat.st_size), | ||
| modificationDate: Date(timeIntervalSince1970: modificationDate) | ||
| ) | ||
| } catch { |
There was a problem hiding this comment.
Is there a known error that would be thrown if the file does not exist?
There was a problem hiding this comment.
It's a NIOCore.IOError(2) but this could change when we move to NIOFileSystem.
Yeah that is a concern. The FileMiddleware covers pretty much all eventualities. The main possibility would be we need another file attribute. |
Joannis
requested changes
Mar 22, 2024
Joannis
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow for writing custom file loaders that cache file contents or use another source than the local file system for files