Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPResponseStatus -> HTTPResponse.Status in documentation #413

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

sidepelican
Copy link
Contributor

In https://docs.hummingbird.codes/2.0/documentation/hummingbird/router ,

router.post("status") { _, _ -> HTTPResponseStatus in
    return .ok
}

This example code cannot compile because HTTPResponseStatus seems to have been renamed to HTTPResponse.Status. This PR updates the documentation comments accordingly.

@sidepelican sidepelican changed the title HTTPResponseStatus -> HTTPResponse.Status HTTPResponseStatus -> HTTPResponse.Status in documentation Mar 29, 2024
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.87%. Comparing base (e78cde7) to head (cb836e4).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #413      +/-   ##
==========================================
- Coverage   84.86%   83.87%   -0.99%     
==========================================
  Files          98      100       +2     
  Lines        5320     4125    -1195     
==========================================
- Hits         4515     3460    -1055     
+ Misses        805      665     -140     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adam-fowler adam-fowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good
thank you

@adam-fowler adam-fowler merged commit 1f7d3c3 into hummingbird-project:main Mar 29, 2024
6 of 7 checks passed
@sidepelican sidepelican deleted the docfix branch March 29, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants