Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove RouteHandler #422

Merged
merged 1 commit into from
Apr 21, 2024
Merged

Remove RouteHandler #422

merged 1 commit into from
Apr 21, 2024

Conversation

adam-fowler
Copy link
Member

They are awkward to use and it is pretty much impossible to inject dependencies into them

They are awkward to use and it is pretty much impossible to inject dependencies into them
@adam-fowler adam-fowler requested a review from Joannis April 21, 2024 10:43
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm all for removing - just two things:

  • Any docs and examples will need to be updated
  • What's the expected impact on current users? Do you expect there to be many? If so, maybe we can deprecate first.

@adam-fowler
Copy link
Member Author

I'm all for removing - just two things:

  • Any docs and examples will need to be updated
  • What's the expected impact on current users? Do you expect there to be many? If so, maybe we can deprecate first.

Yeah, we'll need to remove them from the docs
I don't think there will be much impact. They were of some use in 1.0 but given how awkward they are to use in 2.0 I doubt there is much use.

@adam-fowler adam-fowler merged commit 32a724e into main Apr 21, 2024
4 of 5 checks passed
@adam-fowler adam-fowler deleted the remove-route-handler branch April 21, 2024 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants