Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update content-length header on setting response body #425

Merged
merged 2 commits into from
Apr 23, 2024
Merged

Update content-length header on setting response body #425

merged 2 commits into from
Apr 23, 2024

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Apr 23, 2024 •
edited
Loading

Also add createHeadResponse() to Response so this can be created correctly.

@adam-fowler adam-fowler requested a review from Joannis April 23, 2024 07:20
Joannis
Joannis approved these changes Apr 23, 2024
View reviewed changes
Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. I thought we already had that

@adam-fowler
Copy link
Member Author

Good find. I thought we already had that

It was Dave Delong who found it. I have always built a Response in one go and never updated Response.body after building the Response so never found it previously

@adam-fowler adam-fowler merged commit 44e22bc into main Apr 23, 2024
5 checks passed
@adam-fowler adam-fowler deleted the content-length-header-setting branch April 23, 2024 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Joannis Joannis Joannis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adam-fowler @Joannis