Remove ServerChildChannel generic associatedtype from ApplicationProtocol #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ocol Instead use any ServerChildChannel . We don’t get any real benefit from the parameter being a generic over an existential, it gets converted to an existential Service anyway. But I’ve had to jump through a number of hoops to ensure we can keep generic parameters where they do make a performance improvement. The reason I’m doing this is I was trying to flip between a TLS and non-TLS child channel when build an application and it was really quite awkward as the child channel changed the type of the Application. Removing the ServerChildChannel generic parameter simplifies this considerably.
Joannis
reviewed
Apr 23, 2024
Joannis
reviewed
Apr 23, 2024
Joannis
approved these changes
Apr 23, 2024
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Co-authored-by: Joannis Orlandos <joannis@orlandos.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead use
any ServerChildChannel. We don’t gain any real benefit from the parameter being a generic over an existential, it gets converted to an existentialServiceanyway. But I’ve had to jump through a number of hoops to ensure we can keep generic parameters where they do make a performance improvement.The reason I’m doing this is I was trying to flip between a TLS and non-TLS child channel when build an application and it was really quite awkward as the child channel changed the type of the Application. Removing the ServerChildChannel generic parameter simplifies this considerably.