Playing with naming: rename InstantiableRequestContext to InitializableFromSource and set Source as primary type #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'd like this to become a bit more of a discussion before we make a bunch of PRs to change names. |
|
The PR was meant to be a discussion. We can do this in another forum if you want. I'm not 100% on the name. I think the primary associated type works quite well. |
adam-fowler
changed the title
Joannis
reviewed
Jun 17, 2024
| //===----------------------------------------------------------------------===// | ||
|
|
||
| /// A type that can be initialized from another type | ||
| public protocol InitializableFromSource<Source>: Sendable { |
There was a problem hiding this comment.
Filename needs to change to InitializableFromSource.swift
Joannis
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So
Context: InstantiableRequestContext where Context.Source == TypebecomesContext: InitializedFrom<Type>Also
ServerRequestContextSourcetoApplicationRequestContextSource