Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTP2 improvements #601

Merged
merged 18 commits into from
Nov 6, 2024
Merged

HTTP2 improvements #601

merged 18 commits into from
Nov 6, 2024

Conversation

adam-fowler
Copy link
Member

@adam-fowler adam-fowler commented Nov 2, 2024

  • Added HTTP2ServerConnectionManager to manage graceful close and idle, close, maxAge timeouts. This is heavily based on the gRPC ServerConnectionManager.
  • Added HTTP2StreamChannel to serve a single HTTP request/response pair instead of using the HTTP1Channel
  • Moved HTTP2 tests into their own target

Copy link
Member

@Joannis Joannis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review, I didn't have a complete look through yet

Sources/HummingbirdHTTP2/HTTP2Channel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2Channel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2Channel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2StreamChannel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2StreamChannel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2StreamChannel.swift Outdated Show resolved Hide resolved
Sources/HummingbirdHTTP2/HTTP2StreamChannel.swift Outdated Show resolved Hide resolved
@adam-fowler adam-fowler force-pushed the http2-setup branch 2 times, most recently from e8c8579 to 920e6ab Compare November 6, 2024 11:43
Base automatically changed from channel-configuration to main November 6, 2024 12:14
Copy link

github-actions bot commented Nov 6, 2024

@adam-fowler adam-fowler merged commit 49e4a08 into main Nov 6, 2024
6 of 7 checks passed
@adam-fowler adam-fowler deleted the http2-setup branch November 6, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants