Cancel on inbound close #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
Dec 5, 2024
| @@ -60,10 +65,100 @@ public struct Request: Sendable { | |||
| self.body = .init(buffer: byteBuffer) | |||
| return byteBuffer | |||
| } | |||
|
|
|||
| public func cancelOnInboundClose<Value: Sendable>(_ process: @escaping @Sendable (Request) async throws -> Value) async throws -> Value { | |||
There was a problem hiding this comment.
This should be part of the (Core)RequestContext instead
There was a problem hiding this comment.
Server needs access to this object and it knows nothing about RequestContexts so not sure how we can do this.
|
Need #629 to really make this useful |
|
Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-12-06T16:00:32+00:00 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for cancelling a request when the inbound is closed.
There are limitations
request.cancelOnInboundCloseconsumes the request bodyThe way it works. It runs a task group with one task reading the request inbound stream, and the other running the closure. To avoid the request inbound stream being iterated twice a new version of the request is constructed with a new inbound stream that is being fed by the first of the tasks.
If the request inbound stream hits a second http head (ie the next request) then that is stored in the request iteration state attached to Request.