Storing underlying request part iterator with RequestBody #634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
approved these changes
Dec 11, 2024
adam-fowler
force-pushed
the
cancel-on-inbound-close2
branch
from
c2bbca4 to
7bdc69e
Compare
adam-fowler
force-pushed
the
storing-underlying-request-body
branch
from
4fda44d to
ebee606
Compare
And use in consumeWithInboundCloseHandler
adam-fowler
force-pushed
the
storing-underlying-request-body
branch
from
ebee606 to
102d455
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you try to run
withInboundCloseHandleron a request body that has been edited, there is a good chance you won't have a reference to the original request part iterator that is used to tell if the connection has been closed. If you did have a reference to the original iterator either it had iterated past the request body so couldn't be used to feed the request body inwithInboundCloseHandleror it would provide the buffers from the original request and not the edited buffers.To get around this we
RequestBody.mergeWithUnderlyingRequestPartIteratorwe combine the current RequestBody with the original RequestPart iterator. With this we can supply the RequestBody buffer stream, but then also verify if the connection has been closed.