Router validation #637
Open
Router validation #637
+154
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Joannis
reviewed
Dec 22, 2024
| return true | ||
| } | ||
| guard trieValues.count > 1 else { return } | ||
| for index in 1..<trieValues.count { |
There was a problem hiding this comment.
I think this is computationally much heavier than it needs to be, though it will catch more routes that overlap.
Let's break down what we want to validate (and why) in a discussion somewhere.
There was a problem hiding this comment.
I was intending to catch any route that would never be triggered because a higher priority route was triggered instead.
There was a problem hiding this comment.
Optimised this. It now does the validation at the trie node level which is considerably faster
Joannis
reviewed
Dec 27, 2024
Joannis
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Router.validate()to check whether any route paths clash.Unfortunately cannot add this in
buildResponderas it is a throwing function.