Percent encode, URLEncodedForm using FoundationEssentials

[adam-fowler]

• Replace percentDecode function with internal one removingURLPercentEncoding from FoundationEssentials
• Add addingPercentEncoding
• Use in URLEncodedForm code
• Replace ISO8601 date formatter with 6.0 Date format parser and style if available

And...

• Breaking change: remove URLEncodedFormDecoder.DateDecodingStrategy.formatted and equivalent URLEncodedFormEncoder version. This uses DateFormatter a pre swift 6.0 type. We cannot remove our dependency on Foundation without removing this. In theory we could add a HummingbirdFoundationCompat to include this in as it can be implemented with .custom in a similar way to how JSONEncoder does it.

    public static func formatted(_ formatter: DateFormatter) -> Self {
        .custom { decoder in
            let container = try decoder.singleValueContainer()
            let result = try container.decode(String.self)
            if let date = formatter.date(from: result) {
                return date
            } else {
                throw DecodingError.dataCorrupted(DecodingError.Context(codingPath: decoder.codingPath, debugDescription: "Date string does not match format expected by formatter."))
            }
        }
    }

[github-actions]

Pull request benchmark comparison [ubuntu-latest] with 'main' run at 2024-12-24T12:56:42+00:00

[Joannis]

How does this affect *OS support from Apple?

[Joannis]

How does this affect *OS support from Apple?

[Joannis]

Assuming this doesn't break older Apple OS'es, LGTM