fix: Select and Combobox infinite loop on item select

huntabyte · Nov 14, 2024 · a46e35e · a46e35e
1 parent b00ddf9
commit a46e35e
Show file tree

Hide file tree

Showing 6 changed files with 144 additions and 67 deletions.
diff --git a/.changeset/wise-pumas-help.md b/.changeset/wise-pumas-help.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+fix: `Select` and `Combobox` infinite loop on item selection
diff --git a/packages/bits-ui/package.json b/packages/bits-ui/package.json
@@ -36,7 +36,7 @@
 		"jest-axe": "^9.0.0",
 		"jsdom": "^24.1.0",
 		"publint": "^0.2.11",
-		"svelte": "^5.1.0",
+		"svelte": "^5.1.16",
 		"svelte-check": "4.0.3",
 		"tslib": "^2.7.0",
 		"typescript": "^5.6.2",

diff --git a/packages/bits-ui/src/lib/bits/select/select.svelte.ts b/packages/bits-ui/src/lib/bits/select/select.svelte.ts
@@ -842,7 +842,7 @@ class SelectItemState {
 
 		$effect(() => {
 			if (!this.mounted) return;
-			this.root.setInitialHighlightedNode();
+			untrack(() => this.root.setInitialHighlightedNode());
 		});
 	}